yrtria/MediaShelf
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stop dropping seasons Plex reports without a parentRatingKey

Browse source 
The first real scan logged 15 "episode has no season; skipped" warnings. They
are Firefly S1 in TV Show Archive: Plex returns those episodes with
grandparentRatingKey and parentIndex set and parentGuid present, but
parentRatingKey null. Requiring parentRatingKey meant the entire season was
silently absent from the report - exactly the kind of quiet omission a reclaim
tool must not have.

The season key is now synthesized from show + season number when Plex omits it,
which is stable across scans. Keep marks are unaffected either way since they
key on GUIDs, not rating keys.

Also drops the multi_part flag from ordinary seasons. A season has one part per
episode, so part_count > 1 is normal there and the badge appeared on every TV
row; it now means what it says - a movie held more than once, or a season with
more files than episodes.

Both cases are in the fake server now, so the suite covers them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GVbG48GAXfCZatcmX123Ra
This commit is contained in:
Jess Hallsworth 2026-09-10 14:37:30 +00:00
parent 71cfa31f09
commit d12cbc62ee
No known key found for this signature in database
5 changed files with 66 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/test_ingest.py
View file

@ -119,3 +119,22 @@ def test_refuses_history_from_a_different_plex_server(db, cfg, monkeypatch):
result = ingest.Ingest(db, cfg, media, history).run("full", "manual")
assert result.status == "failed"
assert "different plex server" in (result.error or "").lower()
def test_episodes_without_a_parent_rating_key_still_build_a_season(scanned):
"""Plex omits parentRatingKey on some episodes (Firefly, live). Dropping
them silently lost a whole 15-episode season from the report."""
season = scanned.one(
"SELECT i.*, p.title AS show FROM media_item i "
"JOIN media_item p ON p.id = i.parent_id "
"WHERE i.kind='season' AND p.title='Orphan Show'")
assert season is not None, "season was dropped for want of a parentRatingKey"
assert season["episode_count"] == 5
assert season["size_bytes"] == 5 * 2 * 10**9
assert season["season_number"] == 1
assert ":s1" in season["provider_item_id"], "expected a synthesized season key"
def test_no_orphan_episode_warnings(scanned, rescan):
r = rescan("full")
assert not [w for w in (r.warnings or []) if "no season" in w]

11
tests/test_rules_and_api.py
View file

@ -207,3 +207,14 @@ def test_completion_flag_is_false_for_plex_only_history(scanned):
from mediashelf import queries
scanned.execute("UPDATE watch_event SET percent_complete = NULL")
assert queries.history_has_completion(scanned) is False
def test_multi_part_flag_is_not_set_on_ordinary_seasons(client):
"""A season has one part per episode; flagging that as multi_part put a
meaningless badge on every TV row in the grid."""
data = client.get("/api/v1/items?page_size=500&kind=season").get_json()
seasons = [i for i in data["items"] if i["kind"] == "season"]
assert seasons
bogus = [s for s in seasons
if "multi_part" in s["flags"] and s["part_count"] <= (s["episode_count"] or 0)]
assert not bogus, f"{len(bogus)} seasons flagged multi_part with no extra files"