yrtria/azerothcore-armory
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Activity Actions

chore: minor improvements in for cycle (#18)

Browse source
This commit is contained in:
Stefano Borzì 2022-05-06 20:24:22 +02:00 • committed by GitHub
parent 8331e4dd73
commit 216904fd6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/tools/fetchdata.ts
View file

@ -125,21 +125,17 @@ async function download(dir: string, file: string): Promise<string | any> {
function queueTexturesAndModels(item: any): void {
if (item.TextureFiles !== null) {
for (const key in item.TextureFiles) {
for (const file of item.TextureFiles[key]) {
if (file.FileDataId !== 0) {
texturesDownloadQueue.add(file.FileDataId);
}
for (const file in Object.values(item.TextureFiles)) {
if (file["FileDataId"] !== 0) {
texturesDownloadQueue.add(file["FileDataId"]);
}
}
}
if (item.ModelFiles !== null) {
for (const key in item.ModelFiles) {
for (const file of item.ModelFiles[key]) {
if (file.FileDataId !== 0) {
modelsDownloadQueue.add(file.FileDataId);
}
for (const file of Object.values(item.ModelFiles)) {
if (file["FileDataId"] !== 0) {
modelsDownloadQueue.add(file["FileDataId"]);
}
}
}
@ -149,7 +145,7 @@ function queueTexturesAndModels(item: any): void {
}
if (item.Textures !== null) {
for (const key in item.Textures) {
for (const key of Object.keys(item.Textures)) {
if (item.Textures[key] !== 0) {
texturesDownloadQueue.add(item.Textures[key]);
}
@ -157,7 +153,7 @@ function queueTexturesAndModels(item: any): void {
}
if (item.Textures2 !== null) {
for (const key in item.Textures2) {
for (const key of Object.keys(item.Textures2)) {
if (item.Textures2[key] !== 0) {
texturesDownloadQueue.add(item.Textures2[key]);
}
@ -196,11 +192,9 @@ async function downloadRaces(): Promise<void> {
}
}
const textureFiles = Object.keys(customizationJson.TextureFiles)
.map((key) => customizationJson.TextureFiles[key])
.flat();
const textureFiles = Object.values(customizationJson.TextureFiles).flat();
for (const file of textureFiles) {
texturesDownloadQueue.add(file.FileDataId);
texturesDownloadQueue.add(file["FileDataId"]);
}
progress.increment();