yrtria/azerothcore-armory
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Activity Actions

Show game master characters in the armory
Some checks failed
Build / build (push) Has been cancelled
Details
Lint / eslint (push) Has been cancelled
Details
Build / build (pull_request) Has been cancelled
Details
Lint / eslint (pull_request) Has been cancelled
Details

Browse source 
Upstream hides GM accounts by default, which assumes GM means staff-only.
On this realm GM accounts belong to real players — Spinnaker, the highest
level character on the server, is gmlevel 3 — so the filter was hiding
people who should be listed.

Flips the stack default to 0 and documents both this and the bot filter.
ARMORY_HIDE_GMS=1 restores upstream behaviour.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd
This commit is contained in:
Claude 2026-09-02 20:10:54 +00:00
parent cc7ca06182
commit 6d7398d055
No known key found for this signature in database
2 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
docs/mythica-deploy.md
View file

@ -129,5 +129,10 @@ FLUSH PRIVILEGES;
page rather than shipping both.
- **The Dockerfile builds from `node:16`**, which is end-of-life. It builds and
runs fine; bumping it is a separate change from getting this deployed.
- **`hideGameMasters` defaults to on** here, so GM characters are hidden from
search and return 404.
- **`hideGameMasters` is off** in this stack, unlike upstream. GM accounts on
this realm belong to real players — `Spinnaker` among them — so hiding them
would hide people who should be listed. Set `ARMORY_HIDE_GMS=1` to restore
upstream behaviour.
- **Playerbots are hidden** via `hideBotAccounts` / `botAccountPattern`
(`RNDBOT%`). They are ordinary accounts rather than game masters, so the GM
filter never touched them. `ARMORY_HIDE_BOTS=0` shows them again.