From a12ada69b39528d5b683604193bfe77e909fdf48 Mon Sep 17 00:00:00 2001 From: smthbh Date: Tue, 29 Apr 2025 13:32:48 -0400 Subject: [PATCH 1/3] Remove completed quests from compare --- src/armory/controllers/CharacterController.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/armory/controllers/CharacterController.ts b/src/armory/controllers/CharacterController.ts index b3004c7..4ca1489 100644 --- a/src/armory/controllers/CharacterController.ts +++ b/src/armory/controllers/CharacterController.ts @@ -450,6 +450,10 @@ export class CharacterController { const existingQuest = categories[category].find(q => q.id === quest.id); if (existingQuest) { existingQuest[source] = quest.status; + // Remove quest if both characters have completed it + if (existingQuest.char1Status === 'Completed' && existingQuest.char2Status === 'Completed') { + categories[category] = categories[category].filter(q => q.id !== quest.id); + } } else { categories[category].push({ id: quest.id, From fe26e6e783e69f142062dded7cd52714b24fc070 Mon Sep 17 00:00:00 2001 From: smthbh Date: Tue, 29 Apr 2025 13:33:02 -0400 Subject: [PATCH 2/3] do not highlight in progress vs completed --- static/css/character-quests.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/css/character-quests.css b/static/css/character-quests.css index e54cc68..da4fe09 100644 --- a/static/css/character-quests.css +++ b/static/css/character-quests.css @@ -123,9 +123,9 @@ font-weight: bold; } -tr.quest-diff { +/* tr.quest-diff { background-color: rgba(255, 255, 0, 0.2) !important; -} +} */ tr.quest-missing-1 td:nth-child(3) { background-color: rgba(255, 0, 0, 0.2) !important; From cab24e887a0e32d957ecb7794a0a7bb32cce0b7f Mon Sep 17 00:00:00 2001 From: smthbh Date: Tue, 29 Apr 2025 13:33:13 -0400 Subject: [PATCH 3/3] do not list realm on character select --- static/character-quests-compare.hbs | 2 +- static/character-quests.hbs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/static/character-quests-compare.hbs b/static/character-quests-compare.hbs index b434bff..5862b2a 100644 --- a/static/character-quests-compare.hbs +++ b/static/character-quests-compare.hbs @@ -24,7 +24,7 @@ selected {{/if}} {{/if}}> - {{this.name}} ({{this.realmName}}) + {{this.name}} {{/each}} diff --git a/static/character-quests.hbs b/static/character-quests.hbs index a94ad08..2731852 100644 --- a/static/character-quests.hbs +++ b/static/character-quests.hbs @@ -18,7 +18,7 @@