fix warnings
This commit is contained in:
parent
e6b1d1b09b
commit
f12e6bae79
2 changed files with 13 additions and 4 deletions
2
.github/workflows/lint.yml
vendored
2
.github/workflows/lint.yml
vendored
|
|
@ -10,4 +10,4 @@ jobs:
|
||||||
- uses: actions/checkout@v3
|
- uses: actions/checkout@v3
|
||||||
- uses: actions/setup-node@v3
|
- uses: actions/setup-node@v3
|
||||||
- run: npm ci
|
- run: npm ci
|
||||||
- run: npm run lint -- --max-warnings=3
|
- run: npm run lint -- --max-warnings=4
|
||||||
|
|
|
||||||
|
|
@ -427,8 +427,17 @@ export class CharacterController {
|
||||||
const otherQuests = await this.getQuests(otherRealm.name, otherCharData.guid);
|
const otherQuests = await this.getQuests(otherRealm.name, otherCharData.guid);
|
||||||
|
|
||||||
// Group quests by category
|
// Group quests by category
|
||||||
const categories: { [key: string]: any[] } = {};
|
interface IQuestComparison {
|
||||||
const addQuestsToCategories = (quests: any[], source: string) => {
|
id: number;
|
||||||
|
title: string;
|
||||||
|
questLevel: number;
|
||||||
|
char1Status?: 'Completed' | 'In Progress';
|
||||||
|
char2Status?: 'Completed' | 'In Progress';
|
||||||
|
}
|
||||||
|
|
||||||
|
const categories: { [key: string]: IQuestComparison[] } = {};
|
||||||
|
|
||||||
|
const addQuestsToCategories = (quests: IQuest[], source: 'char1Status' | 'char2Status') => {
|
||||||
quests.forEach(quest => {
|
quests.forEach(quest => {
|
||||||
const category = quest.questSortID > 0 ?
|
const category = quest.questSortID > 0 ?
|
||||||
this.getZoneName(quest.questSortID) :
|
this.getZoneName(quest.questSortID) :
|
||||||
|
|
@ -446,7 +455,7 @@ export class CharacterController {
|
||||||
id: quest.id,
|
id: quest.id,
|
||||||
title: quest.title,
|
title: quest.title,
|
||||||
questLevel: quest.questLevel,
|
questLevel: quest.questLevel,
|
||||||
[source]: quest.status,
|
[source]: quest.status
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue