yrtria/azerothcore-armory
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Activity Actions

Filter several service accounts, not just Playerbots
Some checks failed
Build / build (push) Has been cancelled
Details
Lint / eslint (push) Has been cancelled
Details

Browse source 
The auction-house bot account (ahouse) owns 9 mule characters that were
showing up in the armory alongside real players. One LIKE pattern could not
cover both it and RNDBOT%.

Replaces botAccountPattern with botAccountPatterns, a comma-separated list
of LIKE patterns, and builds the clause with Utils.botAccountFilter. An empty
list now disables the filter outright rather than emitting a clause that
matches nothing, so misconfiguration fails open instead of hiding everyone.

The stack default becomes "RNDBOT%,ahouse"; config.default.json keeps the
generic "RNDBOT%" so the fork stays upstreamable.

Verified against the live realm: 29 listed before, 20 after. The 9 excluded
are the ahouse mules.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd
This commit is contained in:
Claude 2026-09-02 21:28:18 +00:00
parent 0e7cf0f988
commit f505a580d2
No known key found for this signature in database
8 changed files with 48 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/mythica-deploy.md
View file

@ -133,6 +133,8 @@ FLUSH PRIVILEGES;
this realm belong to real players — `Spinnaker` among them — so hiding them
would hide people who should be listed. Set `ARMORY_HIDE_GMS=1` to restore
upstream behaviour.
- **Playerbots are hidden** via `hideBotAccounts` / `botAccountPattern`
(`RNDBOT%`). They are ordinary accounts rather than game masters, so the GM
filter never touched them. `ARMORY_HIDE_BOTS=0` shows them again.
- **Service accounts are hidden** via `hideBotAccounts` / `botAccountPatterns`,
a comma-separated list of LIKE patterns defaulting to `RNDBOT%,ahouse` — the
Playerbots accounts and the auction-house bot, which owns 9 mule characters.
None of them are game masters, so the GM filter never touched them. Add more
with `ARMORY_BOT_PATTERNS`, or set `ARMORY_HIDE_BOTS=0` to show them all.