From 5961c1bd12420330d21224063a97c527124d86c9 Mon Sep 17 00:00:00 2001 From: Walter Pagani Date: Wed, 12 Jul 2023 06:30:52 -0300 Subject: [PATCH] feat. (Repository): Add issue and pull request templates (#26) --- .github/ISSUE_TEMPLATE/bug_report.yml | 72 ++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.yml | 33 ++++++++++ README.md => .github/README.md | 14 +++-- pull_request_template.md | 25 ++++++++ src/mod_congratsonlevel.cpp | 8 +-- 5 files changed, 142 insertions(+), 10 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml rename README.md => .github/README.md (76%) create mode 100644 pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 0000000..5610d2b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,72 @@ +name: Bug report +description: Create a bug report to help us improve. +title: "Bug: " +body: + - type: textarea + id: current + attributes: + label: Current Behaviour + description: | + Description of the problem or issue here. + Include entries of affected creatures / items / quests / spells etc. + If this is a crash, post the crashlog (upload to https://gist.github.com/) and include the link here. + Never upload files! Use GIST for text and YouTube for videos! + validations: + required: true + - type: textarea + id: expected + attributes: + label: Expected Behaviour + description: | + Tell us what should happen instead. + validations: + required: true + - type: textarea + id: reproduce + attributes: + label: Steps to reproduce the problem + description: | + What does someone else need to do to encounter the same bug? + placeholder: | + 1. Step 1 + 2. Step 2 + 3. Step 3 + validations: + required: true + - type: textarea + id: extra + attributes: + label: Extra Notes + description: | + Do you have any extra notes that can help solve the issue that does not fit any other field? + placeholder: | + None + validations: + required: false + - type: textarea + id: commit + attributes: + label: AC rev. hash/commit + description: | + Copy the result of the `.server debug` command (if you need to run it from the client get a prat addon) + validations: + required: true + - type: input + id: os + attributes: + label: Operating system + description: | + The Operating System the Server is running on. + i.e. Windows 11 x64, Debian 10 x64, macOS 12, Ubuntu 20.04 + validations: + required: true + - type: textarea + id: custom + attributes: + label: Custom changes or Modules + description: | + List which custom changes or modules you have applied, i.e. Eluna module, etc. + placeholder: | + None + validations: + required: false diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml new file mode 100644 index 0000000..58f79dd --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -0,0 +1,33 @@ +name: Feature request +description: Suggest an idea for this project +title: "Feature: " +body: + - type: markdown + attributes: + value: | + Thank you for taking your time to fill out a feature request. Remember to fill out all fields including the title above. + An issue that is not properly filled out will be closed. + - type: textarea + id: description + attributes: + label: Describe your feature request or suggestion in detail + description: | + A clear and concise description of what you want to happen. + validations: + required: true + - type: textarea + id: solution + attributes: + label: Describe a possible solution to your feature or suggestion in detail + description: | + A clear and concise description of any alternative solutions or features you've considered. + validations: + required: false + - type: textarea + id: additional + attributes: + label: Additional context + description: | + Add any other context or screenshots about the feature request here. + validations: + required: false diff --git a/README.md b/.github/README.md similarity index 76% rename from README.md rename to .github/README.md index 41efdbd..38f7163 100644 --- a/README.md +++ b/.github/README.md @@ -1,12 +1,15 @@ # ![logo](https://raw.githubusercontent.com/azerothcore/azerothcore.github.io/master/images/logo-github.png) AzerothCore + ## mod-congrats-on-level + ### This is a module for [AzerothCore](http://www.azerothcore.org) -- Latest build status with azerothcore: [![Build Status](https://github.com/azerothcore/mod-congrats-on-level/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/azerothcore/mod-congrats-on-level) + +- Latest build status with azerothcore: + +[![Build Status](https://github.com/azerothcore/mod-congrats-on-level/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/azerothcore/mod-congrats-on-level) #### Features: -This module rewards players when they reach specific levels. It has the option to reward gold, two items, and a -buff or any combination. It also announces to the world when a player levels up. All rewards can be set in the -config file for quick modifications. +This module rewards players when they reach specific levels. It has the option to reward gold, two items, and a buff or any combination. It also announces to the world when a player levels up. All rewards can be set in the config file for quick modifications. ### This module currently requires: - AzerothCore v1.0.1+ @@ -24,7 +27,6 @@ config file for quick modifications. - Enable Module Announce - Set Items/Gold/Buffs Given At Each Level - ## Credits - [SoulSeekkor](https://github.com/SoulSeekkor) - [LordPsyan](https://bitbucket.org/lordpsyan/lordpsyan-patches) @@ -40,6 +42,6 @@ config file for quick modifications. - [OregonCore](https://wiki.oregon-core.net/) - [Wowhead.com](http://wowhead.com) - [AoWoW](https://wotlk.evowow.com/) -- [Stygianthebest]( http://stygianthebest.github.io) +- [Stygianthebest]( http://stygianthebest.github.io) AzerothCore: [repository](https://github.com/azerothcore) - [website](http://azerothcore.org/) - [discord chat community](https://discord.gg/PaqQRkd) diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..21c9245 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,25 @@ + + +## Changes Proposed: +- +- + +## Issues Addressed: + +- Closes + +## SOURCE: + + +## Tests Performed: + +- +- + + +## How to Test the Changes: + + +1. +2. +3. diff --git a/src/mod_congratsonlevel.cpp b/src/mod_congratsonlevel.cpp index b872c38..23e733e 100644 --- a/src/mod_congratsonlevel.cpp +++ b/src/mod_congratsonlevel.cpp @@ -293,14 +293,14 @@ public: sWorld->SendServerMessage(SERVER_MSG_STRING, ss.str().c_str()); // Give the items to the player - player->AddItem(item1, 1); // Defined Item 1 - player->AddItem(item2, 1); // Defined Item 2 + player->AddItem(item1, 1); // Defined Item 1 + player->AddItem(item2, 1); // Defined Item 2 // Give gold to the player - player->ModifyMoney(money*GOLD); // Defined Gold + player->ModifyMoney(money*GOLD); // Defined Gold // Buff the player - player->CastSpell(player, spell); // Defined Spell + player->CastSpell(player, spell); // Defined Spell // Issue a raid warning to the player std::ostringstream ss2;