yrtria/mod-gold-rush
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

base: yrtria:4f7c9f8c622d6a12cc2201d065b256472658122e
Branches Tags
yrtria:main
yrtria:fix/herb-pool-scoping-regression
yrtria:fix/herb-ore-category-lookup
yrtria:fix/player-anchored-site-missing-zone-resources
yrtria:feature/zone-specific-resources-v2
yrtria:docs/zone-specific-resources-spec
yrtria:fix/null-session-broadcast-crash
yrtria:fix/sholazar-area-name
yrtria:fix/review-round-1
...
compare: yrtria:104ff733b351996a1ee1ac91e395fcdd8861d3d6
Branches Tags
yrtria:main
yrtria:fix/herb-pool-scoping-regression
yrtria:fix/herb-ore-category-lookup
yrtria:fix/player-anchored-site-missing-zone-resources
yrtria:feature/zone-specific-resources-v2
yrtria:docs/zone-specific-resources-spec
yrtria:fix/null-session-broadcast-crash
yrtria:fix/sholazar-area-name
yrtria:fix/review-round-1

2 commits
4f7c9f8c62 ... 104ff733b3

Author SHA1 Message Date
Jess Hallsworth
104ff733b3 Merge pull request 'Correct the Sholazar hotspot area name' (#2) from fix/sholazar-area-name into main 2026-09-03 13:33:29 -06:00
Claude
4c3a6c32c8
fix: correct the Sholazar hotspot area name 
AreaTable.dbc names the Sholazar Basin subzone "River's Heart", not "The
River's Heart". ResolveAreaEntry does an exact normalised match, so the
default ZonePool entry never resolved and BuildSites silently dropped it --
the module logged "loaded with 3 hotspot(s)" for a four-entry pool.

Verified against the extracted AreaTable.dbc on the live server: the other
seven zone and area names in the default pool all match exactly.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019vTNrJGsprcjdjjjDJD5ZM
 2026-09-03 19:33:21 +00:00
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
conf/gold_rush.conf.dist
View file

@ -121,9 +121,9 @@ GoldRush.NodeEntries = 191133;190176;190171;190172;189973
# GoldRush.ZonePool
# Description: Semicolon-separated list of eligible zones.
# Use Zone|ApproximateSubArea for a better announcement.
# Default: "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|The River's Heart"
# Default: "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|River's Heart"
GoldRush.ZonePool = "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|The River's Heart"
GoldRush.ZonePool = "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|River's Heart"
#
# GoldRush.Blacklist

2
src/GoldRush.cpp
View file

@ -181,7 +181,7 @@ public:
_config.MinPlayersOnline = std::max<uint32>(1, sConfigMgr->GetOption<uint32>("GoldRush.MinPlayersOnline", 1));
_config.SpawnRadius = sConfigMgr->GetOption<float>("GoldRush.SpawnRadiusYards", 25.0f);
_config.NodeEntries = sConfigMgr->GetOption<std::string>("GoldRush.NodeEntries", "191133;190176;190171;190172;189973");
_config.ZonePool = sConfigMgr->GetOption<std::string>("GoldRush.ZonePool", "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|The River's Heart");
_config.ZonePool = sConfigMgr->GetOption<std::string>("GoldRush.ZonePool", "Un'Goro Crater|Fire Plume Ridge; Winterspring|Frostfire Hot Springs; Eastern Plaguelands|Terrorweb Tunnel; Sholazar Basin|River's Heart");
_config.Blacklist = sConfigMgr->GetOption<std::string>("GoldRush.Blacklist", "Stormwind City; Orgrimmar; Dalaran");
_config.StartMessage = sConfigMgr->GetOption<std::string>("GoldRush.StartMessage", "A seismic anomaly has exposed a massive vein of rich minerals in {}!");
_config.EndMessage = sConfigMgr->GetOption<std::string>("GoldRush.EndMessage", "The Gold Rush in {} has been exhausted.");