Fix ambiguous 'online' column, and filter the auction-house bot too #3

Merged
yrtria merged 1 commit from fix-ambiguous-online into master 2026-09-02 15:12:25 -06:00

1 commit

Author SHA1 Message Date
Claude
0e7cf0f988
Fix ambiguous 'online' column on character pages
Some checks failed
Build / build (push) Waiting to run
Lint / eslint (push) Waiting to run
Build / build (pull_request) Has been cancelled
Lint / eslint (pull_request) Has been cancelled
The bot-account filter joins acore_auth.account, which has its own `online`
column. The character query selected several columns unqualified, so `online`
became ambiguous and every character page returned a 500:

  Error: Column 'online' in field list is ambiguous
    at CharacterController.getCharacterData

Qualifies every column in that SELECT with `characters`, rather than only the
one that collided, so a future join cannot reintroduce this. The search and
guild listings were never affected: DataTablesSsp always qualifies its columns
with the base table, and only this hand-written query did not.

Verified against the live realm - the previously failing query for
Heavenlymagi now returns its row, and a bot name still returns none.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd
2026-09-02 21:10:41 +00:00