yrtria/azerothcore-armory
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Activity Actions

Filter the auction-house bot as well as Playerbots #4

Merged
yrtria merged 1 commit from filter-service-accounts into master 2026-09-02 15:42:23 -06:00
Conversation 0 Commits 1 Files changed 8 +48 -13
yrtria commented 2026-09-02 15:41:31 -06:00
Owner
Copy link

Follow-up to #3. That PR was merged before this commit landed on its branch, so the 500 fix is live but the service-account filter is not — the ahouse mules are still listing.

The auction-house bot account AHOUSE owns 9 level-1 mule characters (Bidfather, Stonks, Lowballer, Sniperewolf…) that appear alongside real players. One LIKE pattern could not cover both that and RNDBOT%.

botAccountPattern becomes botAccountPatterns, a comma-separated list:

ACORE_ARMORY_BOT_ACCOUNT_PATTERNS = RNDBOT%,ahouse

Whitespace around entries is trimmed, and an empty list disables the filter rather than emitting a clause that matches nothing — a misconfiguration shows everyone instead of silently hiding the realm.

The stack default is RNDBOT%,ahouse, so no Portainer env changes are needed. config.default.json keeps the generic RNDBOT% so this stays upstreamable.

Verified against the live realm:

listed before   29
listed after    20     (the 9 ahouse mules)

Clause builder exercised directly against two patterns, stray whitespace, a single pattern, an empty string, and an embedded apostrophe. Typecheck and eslint clean.

The only other non-player account is ACMAINT, which owns no characters and never appears.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd

Follow-up to #3. That PR was merged before this commit landed on its branch, so the 500 fix is live but the service-account filter is not — the `ahouse` mules are still listing. The auction-house bot account `AHOUSE` owns 9 level-1 mule characters (`Bidfather`, `Stonks`, `Lowballer`, `Sniperewolf`…) that appear alongside real players. One LIKE pattern could not cover both that and `RNDBOT%`. `botAccountPattern` becomes **`botAccountPatterns`**, a comma-separated list: ``` ACORE_ARMORY_BOT_ACCOUNT_PATTERNS = RNDBOT%,ahouse ``` Whitespace around entries is trimmed, and an **empty list disables the filter** rather than emitting a clause that matches nothing — a misconfiguration shows everyone instead of silently hiding the realm. The stack default is `RNDBOT%,ahouse`, so no Portainer env changes are needed. `config.default.json` keeps the generic `RNDBOT%` so this stays upstreamable. Verified against the live realm: ``` listed before 29 listed after 20 (the 9 ahouse mules) ``` Clause builder exercised directly against two patterns, stray whitespace, a single pattern, an empty string, and an embedded apostrophe. Typecheck and eslint clean. The only other non-player account is `ACMAINT`, which owns no characters and never appears. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd
yrtria added 1 commit 2026-09-02 15:41:33 -06:00
Filter several service accounts, not just Playerbots
Some checks failed
Build / build (push) Has been cancelled
Details
Lint / eslint (push) Has been cancelled
Details
Build / build (pull_request) Has been cancelled
Details
Lint / eslint (pull_request) Has been cancelled
Details
28b9fd1aee 
The auction-house bot account (ahouse) owns 9 mule characters that were
showing up in the armory alongside real players. One LIKE pattern could not
cover both it and RNDBOT%.

Replaces botAccountPattern with botAccountPatterns, a comma-separated list
of LIKE patterns, and builds the clause with Utils.botAccountFilter. An empty
list now disables the filter outright rather than emitting a clause that
matches nothing, so misconfiguration fails open instead of hiding everyone.

The stack default becomes "RNDBOT%,ahouse"; config.default.json keeps the
generic "RNDBOT%" so the fork stays upstreamable.

Verified against the live realm: 29 listed before, 20 after. The 9 excluded
are the ahouse mules.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NW2ooBP2KPqQVzdZZDMvZd
yrtria merged commit 92fda8086e into master 2026-09-02 15:42:23 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: yrtria/azerothcore-armory#4
No description provided.
Delete branch "filter-service-accounts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?