yrtria/mod-gold-rush
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: zone-specific resource pools across 57 zones (v2 spec) #5

Merged
yrtria merged 2 commits from feature/zone-specific-resources-v2 into main 2026-09-04 14:25:30 -06:00
Conversation 0 Commits 2 Files changed 3 +79 -18
yrtria commented 2026-09-04 14:17:54 -06:00
Owner
Copy link

Implements the parsing/spawning logic from docs/zone-specific-resources-spec.md section 3.

  • Adds NodeEntries and BonusEntries to GoldRushSite.
  • Switches GoldRush.ZonePool to the v2 2-segment format ZoneName|NodeEntries|BonusEntries.
  • Removes the AreaLabel segment; zone names resolve directly against AreaTable.dbc.
  • Adds GoldRush.BonusChancePercent (default 15) for per-node bonus selection.
  • Maintains backward compatibility: zones without entries fall back to the global GoldRush.NodeEntries pool.
  • Updates conf/gold_rush.conf.dist with the full 57-zone pool.
  • Updates CHANGELOG.md.

Relates to #4 (the spec PR).

Implements the parsing/spawning logic from docs/zone-specific-resources-spec.md section 3. - Adds `NodeEntries` and `BonusEntries` to `GoldRushSite`. - Switches `GoldRush.ZonePool` to the v2 2-segment format `ZoneName|NodeEntries|BonusEntries`. - Removes the `AreaLabel` segment; zone names resolve directly against AreaTable.dbc. - Adds `GoldRush.BonusChancePercent` (default 15) for per-node bonus selection. - Maintains backward compatibility: zones without entries fall back to the global `GoldRush.NodeEntries` pool. - Updates `conf/gold_rush.conf.dist` with the full 57-zone pool. - Updates CHANGELOG.md. Relates to #4 (the spec PR).
yrtria added 1 commit 2026-09-04 14:17:55 -06:00 
- GoldRushSite gains NodeEntries and BonusEntries vectors.
- GoldRush.ZonePool now uses the 2-segment v2 format:
  ZoneName|NodeEntries|BonusEntries.
- AreaLabel segment removed; all zone names resolve directly via AreaTable.dbc.
- Per-node bonus chance controlled by GoldRush.BonusChancePercent (default 15).
- Backward compatibility: zones without entries fall back to global NodeEntries.
- conf/gold_rush.conf.dist updated with full 57-zone pool and BonusChancePercent.
- CHANGELOG.md updated.

Implements docs/zone-specific-resources-spec.md section 3.
Relates to PR #4
yrtria added 1 commit 2026-09-04 14:22:35 -06:00 
The hardcoded fallback default for GoldRush.ZonePool still used the
old ZoneName|AreaLabel format after the parser switched to
ZoneName|NodeEntries|BonusEntries. Not a crash risk (BuildNodeEntries
safely no-ops on non-numeric input) but stale and misleading. Cleared
to an empty default -- the real default lives in gold_rush.conf.dist.

Also added CHANGELOG entries for both this PR's zone-specific
resources feature and the earlier null-session broadcast crash fix
(PR #3), neither of which had been logged despite being merged.
yrtria merged commit 28248f0fa7 into main 2026-09-04 14:25:30 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: yrtria/mod-gold-rush#5
No description provided.
Delete branch "feature/zone-specific-resources-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?