yrtria/mod-gold-rush
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: herb/ore categorization broken for most v2 zones #7

Merged
yrtria merged 2 commits from fix/herb-ore-category-lookup into main 2026-09-09 07:33:21 -06:00
Conversation 0 Commits 2 Files changed 3 +182 -3
yrtria commented 2026-09-08 16:56:08 -06:00
Owner
Copy link

Confirmed live in Hellfire Peninsula: SplitByCategory() guesses herb/ore from name keywords (lotus/clover/thorn/bloom, vein) written for the original 5-entry Northrend pool. None of Hellfire's resources (Felweed, Dreaming Glory, Fel Iron Deposit, Adamantite Deposit) match, so both buckets come back empty and it silently falls back to the unsplit pool -- breaking herb/ore alternation for most of the 57 zones from PR #5.

Spec includes the full herb/ore classification for every already-DB-verified entry ID, so this can be a static lookup table instead of another fragile keyword-list patch.

Docs-only -- no code changes in this PR.

Confirmed live in Hellfire Peninsula: SplitByCategory() guesses herb/ore from name keywords (lotus/clover/thorn/bloom, vein) written for the original 5-entry Northrend pool. None of Hellfire's resources (Felweed, Dreaming Glory, Fel Iron Deposit, Adamantite Deposit) match, so both buckets come back empty and it silently falls back to the unsplit pool -- breaking herb/ore alternation for most of the 57 zones from PR #5. Spec includes the full herb/ore classification for every already-DB-verified entry ID, so this can be a static lookup table instead of another fragile keyword-list patch. Docs-only -- no code changes in this PR.
yrtria added 1 commit 2026-09-08 16:56:09 -06:00 
SplitByCategory() guesses herb/ore purely from keywords in the
display name (lotus/clover/thorn/bloom for herb, vein for ore) --
written for the original 5-entry Northrend default pool, never
updated for the ~70 entries the v2 zone-resources feature (PR #5)
introduced. Confirmed live in Hellfire Peninsula: none of its 4
resources (Felweed, Dreaming Glory, Fel Iron Deposit, Adamantite
Deposit) match any keyword, so both herb and ore buckets come back
empty and every zone silently falls back to the unsplit pool --
breaking the intended herb/ore alternation for the large majority of
the 57 configured zones.

Spec provides the full herb/ore classification for every entry ID
already verified against the live DB when the zone pool was built,
so this can be implemented as a static ID lookup instead of
continuing to patch an ever-fragile keyword list.
yrtria added 1 commit 2026-09-08 17:04:10 -06:00 
SplitByCategory() guessed herb/ore from display-name keywords written
for the original 5-entry Northrend pool. Outland/Classic ore uses
'Deposit' not 'Vein', and most herb names match no keyword, so both
buckets came back empty for almost every v2 zone and the code silently
fell back to the unsplit pool (confirmed live in Hellfire Peninsula).

Replace the keyword guess with a static ID->category lookup table built
from the DB-verified entry IDs in docs/zone-specific-resources-spec.md.
The old keyword check is retained only as a fallback for entries not in
the table.
yrtria merged commit 138a79d338 into main 2026-09-09 07:33:21 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: yrtria/mod-gold-rush#7
No description provided.
Delete branch "fix/herb-ore-category-lookup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?