yrtria/mod-gold-rush
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

bug: wrong-zone resources spawning after PR #7 #8

Merged
yrtria merged 2 commits from fix/herb-pool-scoping-regression into main 2026-09-09 20:16:14 -06:00
Conversation 0 Commits 2 Files changed 3 +91 -1
yrtria commented 2026-09-09 19:45:30 -06:00
Owner
Copy link

Live-tested in Durotar after PR #7 merged and rebuilt: spawned Mageroyal almost exclusively, which is not in Durotar's pool at all (verified the live config -- Peacebloom/Silverleaf/Earthroot/Copper Vein, uncorrupted). No ore appeared either, despite Copper Vein containing 'vein' -- which should have matched even before PR #7.

Hypothesis: herb/ore pool building may be filtering against the full lookup-table universe rather than the current site's own configured entries. Needs direct verification against the merged code -- I have not re-opened that diff for this report.

Docs-only -- no code changes in this PR.

Live-tested in Durotar after PR #7 merged and rebuilt: spawned Mageroyal almost exclusively, which is not in Durotar's pool at all (verified the live config -- Peacebloom/Silverleaf/Earthroot/Copper Vein, uncorrupted). No ore appeared either, despite Copper Vein containing 'vein' -- which should have matched even before PR #7. Hypothesis: herb/ore pool building may be filtering against the full lookup-table universe rather than the current site's own configured entries. Needs direct verification against the merged code -- I have not re-opened that diff for this report. Docs-only -- no code changes in this PR.
yrtria added 1 commit 2026-09-09 19:45:32 -06:00 
Live-tested in Durotar after the herb/ore categorization fix merged
and rebuilt: spawned Mageroyal almost exclusively, which is not in
Durotar's configured pool (verified the live config is correct and
uncorrupted -- Peacebloom/Silverleaf/Earthroot/Copper Vein). No ore
appeared either, despite Copper Vein being in the list and containing
the word 'vein' -- which should have matched even the pre-PR-#7
keyword heuristic, suggesting this isn't purely a categorization
issue.

Hypothesis: herb/ore pool building may now filter against the full
set of IDs the lookup table knows about, rather than the current
site's own configured entries. Flagged for direct verification against
the merged code rather than assumed.
yrtria added 1 commit 2026-09-09 20:15:51 -06:00 
GoldRush.ZonePool separates zones with '; ' (semicolon + space) but the
node/bonus entry IDs within a zone with a bare ';'. BuildSites() split on
the bare ';', so each zone's entry list was cut down to its first ID --
which is always a herb. That is why events spawned a single wrong-zone
herb and no ore at all (PR #8).

Split on the two-character '; ' zone delimiter instead, so every zone
keeps its full node and bonus pools.
yrtria merged commit 4ce7ac2b99 into main 2026-09-09 20:16:14 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: yrtria/mod-gold-rush#8
No description provided.
Delete branch "fix/herb-pool-scoping-regression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?